feat: add organization details to audit log response #13961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all audit entries have organization IDs, so this will allow us to test those cases.
code-asher
commented
Jul 19, 2024
code-asher
commented
Jul 19, 2024
6f4b6bf to
8740626
Compare
This replaces the old ID. This is a breaking change but organizations were not being used before.
8740626 to
2b25f46
Compare
Emyrk
reviewed
Jul 22, 2024
There is another test called "organizations" so this distinguishes that this is checking the response itself contains this field. Rename the user test to match.
ebaa981 to
755d189
Compare
But mark it as deprecated.
755d189 to
de75d4f
Compare
Emyrk
approved these changes
Jul 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so the frontend will be able to display the organization name in the audit log row.
I added
MinimalOrganizationto mirrorMinimalUser. It will be omitted if there was no organization, which I felt made more sense in the frontend (rather than the uuid zero value), but I can change that back if we want.This new object replaces the old organization ID property on audit logs. Technically a breaking change? But we were not using it and I doubt anyone else was.
This is explained in the commit message, but
params.OrganizationID == uuid.Nilwas removed from the test audit log creation so I could test audit logs without an org.Part 1 of #13913