chore: renaming index files #1397
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1397 +/- ##
==========================================
+ Coverage 66.90% 67.06% +0.15%
==========================================
Files 288 287 -1
Lines 18857 18850 -7
Branches 241 241
==========================================
+ Hits 12616 12641 +25
+ Misses 4949 4924 -25
+ Partials 1292 1285 -7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Looks great!
One suggestion is to Link your PR to the issue so that it automatically closes when it merges.
There's 2 standard ways to do this, I suggest both:
- Adding a body to your commit message
chore: renaming index files
resolves: #1211
- Adding the same in your PR description
I think we forgot to mention this anywhere in our onboarding docs, especially because we used to use an external tracker where we got this for free through the branch name.
Hope that helps!
Gotcha! Adjusted the description and will do going forward - thanks for the link. |
Renaming
indexfiles to something (a bit) more specific. Resolves #1211.I actually couldn't find that many instances - only the two mentioned in the ticket. I figured we didn't want to rename barrel files or our index page but if you see something, say something!