feat: accept provisioner keys for provisioner auth #13972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
a53ffdb to
e374c42
Compare
948c470 to
32ff000
Compare
Emyrk
reviewed
Jul 23, 2024
Comment on lines
+229
to
+234
| if req.ProvisionerKey != "" { | ||
| headers.Set(ProvisionerDaemonKey, req.ProvisionerKey) | ||
| } | ||
| if req.PreSharedKey != "" { | ||
| headers.Set(ProvisionerDaemonPSK, req.PreSharedKey) | ||
| } |
There was a problem hiding this comment.
Should these be mutually exclusive?
There was a problem hiding this comment.
I wanted it to fail at the API layer instead of silently taking one or the other. I could do a client error but thought it was cleaner to just have the server handle it.
Emyrk
approved these changes
Jul 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this changes:
Provisioner rbac subject will now have org scoped permissions when authenticating with a provisioner keySite org permissions are removed in this process