Skip to content

feat(site): edit organization member roles #13977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 24, 2024
Merged

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Jul 22, 2024

Screenshot 2024-07-22 at 3 46 57 PM

@aslilac aslilac requested a review from BrunoQuaresma July 22, 2024 22:30
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍 but I'm missing the tests.

@BrunoQuaresma

This comment was marked as resolved.

@aslilac
Copy link
Member Author

aslilac commented Jul 23, 2024

Fixed up 1, 2, and 4. As for 3,

We should provide a description for each role in the options.

This would require a fair bit of backend work. Especially for custom roles, I think letting admins enter a role description and surfacing that on the frontend is a good idea, but non-trivial to add.

@aslilac aslilac requested a review from BrunoQuaresma July 24, 2024 01:43
@aslilac aslilac merged commit 38b5738 into main Jul 24, 2024
33 checks passed
@aslilac aslilac deleted the improve-org-members-table branch July 24, 2024 17:36
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants