Skip to content

feat: add organizations filter to audit table #13978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 24, 2024
Merged

feat: add organizations filter to audit table #13978

merged 6 commits into from
Jul 24, 2024

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Jul 23, 2024 •
edited
Loading

It also removes tracking the org ID from some diffs, since it never changes, for consistency.

The filters take up a good amount of space. At some point maybe they need to be collapsible or go under the search input or something.

Some thoughts I had:

EDIT: will revisit these thoughts after the new mocks, for now we can leave the org info where it is.

  • Should the organization be linked as it currently is? Seems useful but also the blue feels noisy.
  • Instead of having it on the right, could add "in organization $org" to the left side text. For example "created template docker in organization $org" or even "created template docker in $org"
  • I put Org: because Organization: felt long and unbalanced, but now it looks sorta unprofessional.
  • Maybe org should go first before ip/browser/os.

Part 2 of #13913

audit log

audit log with org filter

@code-asher code-asher changed the title Add organizations filter to audit table feat: add organizations filter to audit table Jul 23, 2024
@code-asher code-asher force-pushed the asher/audit-row-org-details branch from 53e78a1 to 7d28771 Compare July 23, 2024 00:12
@code-asher
Copy link
Member Author

Example of that second idea:

org inline

@code-asher code-asher force-pushed the asher/audit-row-org-details branch 3 times, most recently from 1938f07 to 8c32123 Compare July 23, 2024 00:39
@code-asher code-asher requested review from a team and jaaydenh and removed request for a team July 23, 2024 03:06
@code-asher
Copy link
Member Author

code-asher commented Jul 23, 2024 •
edited
Loading

Just realized I need to gate this using the multi-org experiment. done

@code-asher
Copy link
Member Author

code-asher commented Jul 23, 2024 •
edited
Loading

Some more mocks are coming so the way we show the org on the page might change, so for now I think we can ignore where exactly it should go.

@code-asher
Copy link
Member Author

Looks like we are not actually going to have an organization filter dropdown which is a big part of this PR so I am going to extract the parts we still need and open a new PR.

@code-asher code-asher closed this Jul 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
@code-asher code-asher reopened this Jul 24, 2024
@code-asher
Copy link
Member Author

code-asher commented Jul 24, 2024 •
edited
Loading

Uhh nevermind, this is still applicable. We will have this main view then the org > audit link will redirect here with an organization filter set, for now anyway. Went ahead and rebased on main while I was reopening.

@code-asher
Ignore organization ID in audit logs
733b7f4
@code-asher
Add organization to audit log rows
abcdd01
@code-asher
Add organizations filter to audit table
0588a53
@code-asher
Decrease audit filter button widths
8556f92 
Now that there are four items.
@code-asher
Add more audit mocks
00ef754 
To test different org names and no org.
@code-asher
Check multi-org before adding org filter and details
aff7321 
As part of this, make the width adjustable so we only lower it when we
have the new filter added.
@code-asher code-asher force-pushed the asher/audit-row-org-details branch from 93734dc to aff7321 Compare July 24, 2024 18:51
jaaydenh
jaaydenh approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@jaaydenh jaaydenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. When we come back to remove the experiment, I think it would be a good idea to remove setting the explicit width that is added here.

@code-asher
Copy link
Member Author

When we come back to remove the experiment, I think it would be a good idea to remove setting the explicit width that is added here.

Good point! I will make a note.

@code-asher code-asher merged commit e8b3db8 into main Jul 24, 2024
33 checks passed
@code-asher code-asher deleted the asher/audit-row-org-details branch July 24, 2024 22:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jaaydenh jaaydenh jaaydenh approved these changes

Assignees

@code-asher code-asher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@code-asher @jaaydenh