Skip to content

chore(scripts): fix cherry-pick check in check_commit_metadata.sh #13980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Jul 23, 2024

Even though we tracked renamed cherry-picks, the data wasn't being utilized. We also accidentally skipped one row when we found a renamed commit containing "cherry picked from commit". This PR fixes both issues.

@mafredri mafredri changed the title chore(scripts): fix cherry-pick check in check_commit_metadata.sh chore(scripts): fix cherry-pick check in check_commit_metadata.sh Jul 23, 2024
@mafredri mafredri marked this pull request as ready for review July 23, 2024 06:33
@mafredri mafredri added the hotfix PRs only. Harmless small change. Only humans may set this. label Jul 23, 2024
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@mafredri mafredri enabled auto-merge (squash) July 23, 2024 06:38
@mafredri mafredri merged commit 5a4dbcf into main Jul 23, 2024
39 checks passed
@mafredri mafredri deleted the mafredri/chore-scripts-fix-commit-metadata-check branch July 23, 2024 06:49
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant