Skip to content

chore: add eslint extension recommendation #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2022
Merged

chore: add eslint extension recommendation #1400

merged 1 commit into from
May 11, 2022

Conversation

Kira-Pilot
Copy link
Member

Resolves #1399.

Screen Shot 2022-05-11 at 4 43 54 PM

@Kira-Pilot Kira-Pilot requested a review from a team May 11, 2022 21:40
greyscaled
greyscaled approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@codecov
Copy link

codecov bot commented May 11, 2022 •
edited
Loading

Codecov Report

Merging #1400 (49fa840) into main (be3bc5c) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1400      +/-   ##
==========================================
+ Coverage   66.94%   66.96%   +0.01%     
==========================================
  Files         287      287              
  Lines       18850    18850              
  Branches      241      241              
==========================================
+ Hits        12620    12622       +2     
  Misses       4940     4940              
+ Partials     1290     1288       -2
Flag Coverage Δ
unittest-go-macos-latest 54.18% <ø> (+0.08%) ⬆️
unittest-go-postgres- 65.36% <ø> (-0.07%) ⬇️
unittest-go-ubuntu-latest 56.39% <ø> (-0.05%) ⬇️
unittest-go-windows-2022 52.42% <ø> (+0.05%) ⬆️
unittest-js 74.24% <ø> (ø)
Impacted Files Coverage Δ
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
cli/cliui/agent.go 77.46% <0.00%> (-4.23%) ⬇️
peerbroker/listen.go 84.03% <0.00%> (-3.37%) ⬇️
coderd/workspaceagents.go 55.34% <0.00%> (-2.56%) ⬇️
cli/cliui/provisionerjob.go 76.42% <0.00%> (-2.15%) ⬇️
provisioner/echo/serve.go 56.80% <0.00%> (ø)
site/src/components/UserDropdown/UsersDropdown.tsx 96.15% <0.00%> (ø)
site/src/testHelpers/index.tsx
site/src/api/index.ts
site/src/api/api.ts 70.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be3bc5c...49fa840. Read the comment docs.

@Kira-Pilot Kira-Pilot merged commit 2569787 into main May 11, 2022
@Kira-Pilot Kira-Pilot deleted the add-eslint-to-recommendations/kira-pilot branch May 11, 2022 23:01
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@Kira-Pilot @kylecarbs
chore: add eslint extension recommendation (#1400)
fee541d 
resolves #1399
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greyscaled greyscaled greyscaled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ESLint to recommended extensions list
2 participants
@Kira-Pilot @greyscaled