feat: notify about created user account #14010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Meticulous spotted visual differences in 11 of 1069 screens tested: view and approve differences detected. Last updated for commit 77c0c28. This comment will update as new commits are pushed. |
5 tasks
dannykopping
approved these changes
Jul 30, 2024
| require.Contains(t, notifyEnq.Sent[0].Targets, workspace.OrganizationID) | ||
| require.Contains(t, notifyEnq.Sent[0].Targets, workspace.OwnerID) | ||
| require.Len(t, notifyEnq.Sent, 2) | ||
| // notifyEnq.Sent[0] is an event for created user account |
There was a problem hiding this comment.
Nit: would be safer to validate this
There was a problem hiding this comment.
I left it like this on purpose, this is not the aim of this test. Less chance that it will require refining if we alter something in Notifications Enqueuer logic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: coder/internal#17
This PR extends
api.CreateUserto notify owners and user admins when somebody manually creates a new user.