Skip to content

fix: missing return when template version is not found #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2022

Conversation

code-asher
Copy link
Member

Split out from #1394 for changelog purposes

@greyscaled greyscaled changed the title Add missing return when template version is not found fix: missing return when template version is not found May 11, 2022
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #1402 (f5d1b62) into main (982769f) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1402      +/-   ##
==========================================
- Coverage   66.90%   66.87%   -0.03%     
==========================================
  Files         288      287       -1     
  Lines       18857    18851       -6     
  Branches      241      241              
==========================================
- Hits        12616    12607       -9     
- Misses       4949     4950       +1     
- Partials     1292     1294       +2     
Flag Coverage Δ
unittest-go-macos-latest 53.97% <100.00%> (-0.07%) ⬇️
unittest-go-postgres- 65.44% <100.00%> (+0.07%) ⬆️
unittest-go-ubuntu-latest 56.37% <100.00%> (-0.13%) ⬇️
unittest-go-windows-2022 52.32% <100.00%> (-0.06%) ⬇️
unittest-js 74.24% <ø> (ø)
Impacted Files Coverage Δ
coderd/organizations.go 56.23% <100.00%> (-1.01%) ⬇️
coderd/turnconn/turnconn.go 81.91% <0.00%> (-3.20%) ⬇️
peer/conn.go 79.36% <0.00%> (-1.72%) ⬇️
codersdk/workspaceagents.go 51.52% <0.00%> (-1.36%) ⬇️
cli/templates.go 100.00% <0.00%> (ø)
site/src/components/UserDropdown/UsersDropdown.tsx 96.15% <0.00%> (ø)
cli/templateedit.go
site/src/testHelpers/index.tsx
site/src/api/index.ts
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 982769f...f5d1b62. Read the comment docs.

@code-asher code-asher merged commit ce660f8 into main May 11, 2022
@code-asher code-asher deleted the asher/missing-return branch May 11, 2022 22:58
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants