Skip to content

chore(testutil): add testutil.GetRandomName that does not return duplicates #14020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

johnstcn
Copy link
Member

Fixes #13910

Adds testutil.GetRandomName that replaces namesgenerator.GetRandomName but instead appends a monotonically increasing integer instead of a number between 1 and 10.

@johnstcn johnstcn requested review from spikecurtis and Emyrk July 25, 2024 20:57
@johnstcn johnstcn self-assigned this Jul 25, 2024
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am really curious how high this number gets from all our tests 😄.

Not necessary in this PR, but we could add a linter to make sure no one uses the old one.

@johnstcn johnstcn merged commit 37a859f into main Jul 26, 2024
29 checks passed
@johnstcn johnstcn deleted the cj/testutil-getrandomname branch July 26, 2024 08:44
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake: TestTracker_MultipleInstances
2 participants