chore: embed audit log in deployment settings page #14023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing link remains but will redirect to the new URL.
Otherwise the input is teeny tiny and barely fits a few characters.
a0d9df0 to
64d5d67
Compare
|
@bcpeinhardt it auto-assigned you when I selected the ts group but no pressure (unless you want to review); I am going to reassign to someone on 🍌 |
Only for multi-org; single-org setups remain unaffected.
64d5d67 to
2ed12e1
Compare
aslilac
approved these changes
Jul 26, 2024
Comment on lines
+5
to
+7
| export function withFilter(path: string, filter: string) { | ||
| return path + (filter ? `?filter=${encodeURIComponent(filter)}` : ""); | ||
| } |
Co-authored-by: Kayla Washburn-Love <mckayla@hey.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first thing is moving the audit log from
/auditto/deployment/auditwhen multi-org is enabled. Although we have a redirect in place for the old URL, I changed the deployment dropdown link to go directly to the new spot (I also tweak the users link while I was there to do the same).The second thing is making the per-org auditing links go to the main audit log with a pre-filled organization. Note this conflicts with the description in #13958 but fulfills #13913. I think we will probably want to revisit and decide what exactly we want to do here. I have many thoughts. :D
The third thing is to make the filters wrap immediately when on the settings page because the text input is too small otherwise. For comparison:
And fourth, the information is now in a tooltip while under multi-org. This is to compensate for the sidebar and for the extra organization information.
There should be no changes without multi-org enabled (except the flex-grow making the filter menus expand when on smaller screens).
Part 1 of #13958
Part 3 of and closes #13913