Skip to content

fix(examples): use more precise example kubernetes template labels #14028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2024
Merged

fix(examples): use more precise example kubernetes template labels #14028

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98eaf34
fix: apply more specific selector labels to k8s example deployment te…
geniass Jul 26, 2024
bf1ea39
fix: use immutable ids instead of names for persistent resources in k…
geniass Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: use immutable ids instead of names for persistent resources in k… 
…8s example template as per docs
  • Loading branch information
@geniass
geniass committed Jul 31, 2024
commit bf1ea39618eff97638412b75045e02c65e8682f9
16 changes: 6 additions & 10 deletions examples/templates/kubernetes/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,6 @@ provider "kubernetes" {
data "coder_workspace" "me" {}
data "coder_workspace_owner" "me" {}

locals {
workspace_instance = "${lower(data.coder_workspace_owner.me.name)}-${lower(data.coder_workspace.me.name)}"
}

resource "coder_agent" "main" {
os = "linux"
arch = "amd64"
Expand Down Expand Up @@ -194,11 +190,11 @@ resource "coder_app" "code-server" {

resource "kubernetes_persistent_volume_claim" "home" {
metadata {
name = "coder-${local.workspace_instance}-home"
name = "coder-${data.coder_workspace.me.id}-home"
namespace = var.namespace
labels = {
"app.kubernetes.io/name" = "coder-pvc"
"app.kubernetes.io/instance" = "coder-pvc-${local.workspace_instance}"
"app.kubernetes.io/instance" = "coder-pvc-${data.coder_workspace.me.id}"
"app.kubernetes.io/part-of" = "coder"
//Coder-specific labels.
"com.coder.resource" = "true"
Expand Down Expand Up @@ -229,11 +225,11 @@ resource "kubernetes_deployment" "main" {
]
wait_for_rollout = false
metadata {
name = "coder-${local.workspace_instance}"
name = "coder-${data.coder_workspace.me.id}"
namespace = var.namespace
labels = {
"app.kubernetes.io/name" = "coder-workspace"
"app.kubernetes.io/instance" = "coder-workspace-${local.workspace_instance}"
"app.kubernetes.io/instance" = "coder-workspace-${data.coder_workspace.me.id}"
"app.kubernetes.io/part-of" = "coder"
"com.coder.resource" = "true"
"com.coder.workspace.id" = data.coder_workspace.me.id
Expand All @@ -251,7 +247,7 @@ resource "kubernetes_deployment" "main" {
selector {
match_labels = {
"app.kubernetes.io/name" = "coder-workspace"
"app.kubernetes.io/instance" = "coder-workspace-${local.workspace_instance}"
"app.kubernetes.io/instance" = "coder-workspace-${data.coder_workspace.me.id}"
"app.kubernetes.io/part-of" = "coder"
"com.coder.resource" = "true"
"com.coder.workspace.id" = data.coder_workspace.me.id
Expand All @@ -268,7 +264,7 @@ resource "kubernetes_deployment" "main" {
metadata {
labels = {
"app.kubernetes.io/name" = "coder-workspace"
"app.kubernetes.io/instance" = "coder-workspace-${local.workspace_instance}"
"app.kubernetes.io/instance" = "coder-workspace-${data.coder_workspace.me.id}"
"app.kubernetes.io/part-of" = "coder"
"com.coder.resource" = "true"
"com.coder.workspace.id" = data.coder_workspace.me.id
Expand Down
Loading