chore: update generated files after pnpm upgrade #14036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <danny@coder.com>
|
Not really sure why CI is failing. |
|
Sorry about taking a bit to review, I think the reason it's failing is bc I neglected to update pnpm in CI. That should fix it |
coadler
approved these changes
Jul 31, 2024
|
No worries @coadler 👍 https://github.com/coder/coder/actions/runs/10143062920/job/28043671521?pr=14036 |
|
I think the bump from v8 -> v9 changed lockfile formats, so maybe that's what v8 errors with when it sees the new format? |
|
Any idea how to resolve it? |
Signed-off-by: Danny Kopping <danny@coder.com>
|
✅ Meticulous spotted zero visual differences across 1072 screens tested: view results. Expected differences? Click here. Last updated for commit 5d720b4. This comment will update as new commits are pushed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm unsure how
maingot into this state, but when runningmake genin one of my branches it produces diffs in these files.@coadler maybe you know? I guess this should've changed after #13843 so maybe our
make gentarget is buggy?