chore: always use new codepath over deprecated #14050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Meticulous spotted zero visual differences across 1072 screens tested: view results. Expected differences? Click here. Last updated for commit ca28cea. This comment will update as new commits are pushed. |
aslilac
reviewed
Jul 30, 2024
Comment on lines
+490
to
502
| if httpapi.Is404Error(err) { | ||
| httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{ |
There was a problem hiding this comment.
maybe we should actually send a http.StatusNotFound for this then
There was a problem hiding this comment.
Since it the request is trying to create a workspace, I am not sure if a 404 makes much sense to the caller? The error indicates why the request failed, being the template does not exist.
Comment on lines
+478
to
+479
| func (c *Client) CreateWorkspace(ctx context.Context, _ uuid.UUID, user string, request CreateWorkspaceRequest) (Workspace, error) { | ||
| return c.CreateUserWorkspace(ctx, user, request) |
aslilac
approved these changes
Jul 30, 2024
a583cd5 to
005dcd3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use deprecated endpoints in tests. Maybe we should keep a legacy test or two?