Skip to content

ci: handle retriggering ci and human authors in update-flake #14052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

@matifali matifali requested a review from kylecarbs July 30, 2024 08:00
@matifali matifali requested a review from coadler July 30, 2024 08:00
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 1
token: ${{ secrets.CDRCI_GITHUB_TOKEN }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This secret is already available in Secrets. I assume that it has push/write access to the repo. We need to add/update a secret if it does not work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a PAT for the cdrci account with write perms, so it should be fine writing to PRs on this repo.

@matifali matifali force-pushed the matifali/ci-fixup branch 2 times, most recently from 136ac14 to d9cb961 Compare July 30, 2024 08:23
…thors

Improves #14046
Solved the CI stuck issue exhibited in
- #14039
- #14040
- #14041
- #14044
Copy link

alwaysmeticulous bot commented Jul 30, 2024

✅ Meticulous spotted zero visual differences across 932 screens tested: view results.

Expected differences? Click here. Last updated for commit c4cf764. This comment will update as new commits are pushed.

@matifali matifali force-pushed the matifali/ci-fixup branch from d9cb961 to c15cf47 Compare July 30, 2024 08:25
@matifali matifali requested a review from deansheather July 30, 2024 11:46
matifali and others added 3 commits July 31, 2024 19:02
Co-authored-by: Dean Sheather <dean@deansheather.com>
Co-authored-by: Dean Sheather <dean@deansheather.com>
@matifali matifali enabled auto-merge (squash) July 31, 2024 16:09
@matifali matifali merged commit 7a4737c into main Jul 31, 2024
33 checks passed
@matifali matifali deleted the matifali/ci-fixup branch July 31, 2024 16:12
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants