fix: block creating oidc users when oidc has not been configured #14064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
|
✅ Meticulous spotted zero visual differences across 932 screens tested: view results. Expected differences? Click here. Last updated for commit 6585dc2. This comment will update as new commits are pushed. |
deansheather
approved these changes
Jul 31, 2024
Emyrk
approved these changes
Jul 31, 2024
kylecarbs
approved these changes
Jul 31, 2024
663a3ba to
6585dc2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered as it was possible to cause an (albeit recoverable) nil dereference when updating the roles of an OIDC user when OIDC had not yet been configured.