chore: document RBAC usage #14065
Merged
chore: document RBAC usage #14065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Emyrk
reviewed
Jul 31, 2024
There was a problem hiding this comment.
This overall looks good. The one missing piece is RBACObject() and the organizational scoping.
Something to note, if you use InOrg(), then you must be a member of the organization as well. What this means is if you have the user Alice make a workspace Worble in organization Orange, and Alice leaves the org, she can no longer use the workspace.
Despite having the user permission to do so.
This is stated here in the rego:
Lines 241 to 243 in ceffff9
So the truth table for not being in an org (if the resource belongs to an org) has a Negative in the Org column.
|
@johnstcn thanks for reopening; I'll try get to this today or tomorrow. |
Signed-off-by: Danny Kopping <danny@coder.com>
- Truth table had an incorrect result value in final row - Permission format examples was missing the object type - Fix actions list - Code block a bash command
Co-authored-by: Steven Masley <Emyrk@users.noreply.github.com>
Signed-off-by: Danny Kopping <danny@coder.com>
753e3e2 to
cf25746
Compare
johnstcn
approved these changes
Sep 10, 2024
Co-authored-by: Cian Johnston <cian@coder.com>
Co-authored-by: Steven Masley <Emyrk@users.noreply.github.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses #14055 (credit to @johnstcn!) as a reference to demonstrate the use of the RBAC system.