Skip to content

fix: Improve develop script to start tunnel by default #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2022
Merged

fix: Improve develop script to start tunnel by default #1409

merged 1 commit into from
May 12, 2022

Conversation

kylecarbs
Copy link
Member

This allows for running the development script to actually
build workspaces!

@kylecarbs
fix: Improve develop script to start tunnel by default
3e64aab 
This allows for running the development script to actually
build workspaces!
@kylecarbs kylecarbs requested a review from presleyp May 12, 2022 16:43
@kylecarbs kylecarbs self-assigned this May 12, 2022
@kylecarbs kylecarbs requested a review from a team as a code owner May 12, 2022 16:43
@codecov
Copy link

codecov bot commented May 12, 2022 •
edited
Loading

Codecov Report

Merging #1409 (3e64aab) into main (f581724) will increase coverage by 0.31%.
The diff coverage is 26.66%.

@@            Coverage Diff             @@
##             main    #1409      +/-   ##
==========================================
+ Coverage   66.97%   67.29%   +0.31%     
==========================================
  Files         288      288              
  Lines       18857    19111     +254     
  Branches      241      241              
==========================================
+ Hits        12630    12860     +230     
+ Misses       4939     4937       -2     
- Partials     1288     1314      +26
Flag Coverage Δ
unittest-go-macos-latest 54.50% <26.66%> (+0.45%) ⬆️
unittest-go-postgres- 65.79% <26.66%> (+0.36%) ⬆️
unittest-go-ubuntu-latest 56.79% <26.66%> (+0.35%) ⬆️
unittest-go-windows-2022 52.76% <26.66%> (+0.32%) ⬆️
unittest-js 74.19% <ø> (-0.05%) ⬇️
Impacted Files Coverage Δ
cli/server.go 58.08% <26.66%> (+0.59%) ⬆️
provisioner/echo/serve.go 56.80% <0.00%> (-2.41%) ⬇️
agent/agent.go 65.90% <0.00%> (-1.24%) ⬇️
coderd/organizations.go 56.23% <0.00%> (-1.01%) ⬇️
provisionerd/provisionerd.go 76.97% <0.00%> (-0.67%) ⬇️
coderd/database/queries.sql.go 77.78% <0.00%> (-0.13%) ⬇️
cli/templates.go 100.00% <0.00%> (ø)
site/src/testHelpers/entities.ts 100.00% <0.00%> (ø)
site/src/components/Table/Table.tsx 96.00% <0.00%> (ø)
site/src/forms/CreateTemplateForm.tsx 96.29% <0.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f581724...3e64aab. Read the comment docs.

@kylecarbs kylecarbs merged commit 7b5300d into main May 12, 2022
@kylecarbs kylecarbs deleted the embeddevelop branch May 12, 2022 17:37
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs added a commit that referenced this pull request Jun 10, 2022
@kylecarbs
fix: Improve develop script to start tunnel by default (#1409)
919af64 
This allows for running the development script to actually
build workspaces!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@presleyp presleyp presleyp approved these changes

@greyscaled greyscaled greyscaled approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.
4 participants
@kylecarbs @presleyp @greyscaled @misskniss