Skip to content

docs: clone git repositories #14090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

No description provided.

@BrunoQuaresma BrunoQuaresma requested review from bpmct and stirby August 1, 2024 13:16
@BrunoQuaresma BrunoQuaresma self-assigned this Aug 1, 2024
@BrunoQuaresma BrunoQuaresma changed the title docs: cloning git repositories docs: clone git repositories Aug 1, 2024
Copy link

alwaysmeticulous bot commented Aug 1, 2024

🤖 Meticulous replayed 100 user sessions and took 759 visual snapshots. Meticulous has not yet run on 956d0cb of the main branch and so there was nothing to compare against.
If you recently setup Meticulous, this is expected. Meticulous will start reporting comparisons for new pull requests after the next commit to the main branch.

Last updated for commit 7b6f49b. This comment will update as new commits are pushed.

Copy link
Collaborator

@stirby stirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@stirby stirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be referenced in the manifest.json file to appear under guides.

@BrunoQuaresma BrunoQuaresma requested a review from stirby August 6, 2024 14:33
stirby
stirby previously requested changes Aug 6, 2024
Copy link
Collaborator

@stirby stirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think links to the other supported Git providers would help as well.

@BrunoQuaresma BrunoQuaresma requested a review from stirby August 6, 2024 15:27
@BrunoQuaresma BrunoQuaresma dismissed stirby’s stale review August 13, 2024 14:12

Applied all the suggestions

Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrunoQuaresma BrunoQuaresma merged commit f1feb40 into main Aug 13, 2024
25 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/docs-add-cloning-git-guide branch August 13, 2024 15:55
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants