Skip to content

fix: don't require organization_id in body when updating a custom role #14102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Aug 1, 2024

cc @jaaydenh

The extra field doesn't serve much purpose, and results in a more fragile API that's harder to use from the frontend.

@aslilac aslilac requested a review from Emyrk August 1, 2024 22:18
@aslilac aslilac force-pushed the no-org-id-in-role-patch-body branch from 9f93752 to d818498 Compare August 1, 2024 22:26
Copy link

alwaysmeticulous bot commented Aug 2, 2024

✅ Meticulous spotted zero visual differences across 759 screens tested: view results.

Expected differences? Click here. Last updated for commit 9ecefae. This comment will update as new commits are pushed.

@aslilac aslilac merged commit 166467c into main Aug 2, 2024
33 checks passed
@aslilac aslilac deleted the no-org-id-in-role-patch-body branch August 2, 2024 17:25
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants