fix: correct typo in notification template #14108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannykopping
approved these changes
Aug 2, 2024
| @@ -0,0 +1,5 @@ | |||
| UPDATE notification_templates | |||
There was a problem hiding this comment.
I don't really see value in restoring the typo in the down migration.
| @@ -0,0 +1,5 @@ | |||
| UPDATE notification_templates | |||
| SET | |||
| body_template = E'Hi {{.UserName}},\n\nNew user account **{{.Labels.created_account_name}}** has been created.' | |||
There was a problem hiding this comment.
This was incorrectly set in the initial migration, let's sneak it in here if you don't mind
Suggested change
| body_template = E'Hi {{.UserName}},\n\nNew user account **{{.Labels.created_account_name}}** has been created.' | |
| body_template = E'Hi {{.UserName}},\n\nNew user account **{{.Labels.created_account_name}}** has been created.', | |
| group = 'User Events' |
There was a problem hiding this comment.
I would rather keep this idempotent. It does not seem to be an urgent fix that requires modifying existing files, and if there are some scripts checking the content of migration files, and I wouldn't like to make them suffer.
There was a problem hiding this comment.
Maybe you missed the content of the change? The event is a user event, but its group is incorrectly set to Workspace Events currently.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #14010
There is a typo in the notification template, unescaped character.