Skip to content

fix: remove unimplemented account links #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2022
Merged

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented May 12, 2022

It appears unclear as of now when/if these will be implemented so I
opted to remove them (as opposed to commenting them out) to avoid having
them rot (they are easily added back anyway).

Closes #1232.

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #1411 (2162785) into main (26b04cc) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1411      +/-   ##
==========================================
- Coverage   67.29%   67.23%   -0.06%     
==========================================
  Files         288      286       -2     
  Lines       19109    19097      -12     
  Branches      241      241              
==========================================
- Hits        12859    12840      -19     
- Misses       4936     4938       +2     
- Partials     1314     1319       +5     
Flag Coverage Δ
unittest-go-macos-latest 54.48% <ø> (-0.09%) ⬇️
unittest-go-postgres- 65.72% <ø> (-0.05%) ⬇️
unittest-go-ubuntu-latest 56.74% <ø> (-0.05%) ⬇️
unittest-go-windows-2022 52.80% <ø> (+0.01%) ⬆️
unittest-js 74.65% <ø> (+0.45%) ⬆️
Impacted Files Coverage Δ
site/src/AppRouter.tsx 0.00% <ø> (ø)
...components/PreferencesLayout/PreferencesLayout.tsx 0.00% <ø> (ø)
codersdk/provisionerdaemons.go 61.97% <0.00%> (-5.64%) ⬇️
peer/conn.go 78.86% <0.00%> (-3.44%) ⬇️
peerbroker/listen.go 84.03% <0.00%> (-3.37%) ⬇️
agent/agent.go 65.90% <0.00%> (-1.24%) ⬇️
provisionerd/provisionerd.go 77.24% <0.00%> (+0.26%) ⬆️
coderd/workspaceagents.go 56.97% <0.00%> (+0.93%) ⬆️
cli/cliui/agent.go 81.69% <0.00%> (+4.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b04cc...2162785. Read the comment docs.

It appears unclear as of now when/if these will be implemented so I
opted to remove them (as opposed to commenting them out) to avoid having
them rot (they are easily added back anyway).

Closes #1232.
@code-asher code-asher force-pushed the asher/remove-account-links branch from 1249b52 to 2162785 Compare May 12, 2022 17:25
@code-asher code-asher marked this pull request as ready for review May 12, 2022 18:05
@code-asher code-asher requested a review from a team as a code owner May 12, 2022 18:05
@code-asher code-asher merged commit 6f7d9bb into main May 12, 2022
@code-asher code-asher deleted the asher/remove-account-links branch May 12, 2022 18:34
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
It appears unclear as of now when/if these will be implemented so I
opted to remove them (as opposed to commenting them out) to avoid having
them rot (they are easily added back anyway).

Closes #1232.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: User Page - Security and Linked Accounts should not be shown
5 participants