feat: notify when a user account is deleted #14113
Conversation
| if err != nil { | ||
| return nil, xerrors.Errorf("get owners: %w", err) | ||
| } | ||
| userAdmins, err := store.GetUsers(ctx, database.GetUsersParams{ |
There was a problem hiding this comment.
Do we also need to include org user admins here?
There was a problem hiding this comment.
Probably, I will leave it as a follow-up once the org part is final. Most likely we need to adjust create account logic too.
| // then | ||
| require.Len(t, notifyEnq.Sent, 2) | ||
| // notifyEnq.Sent[0] is create account event | ||
| require.Equal(t, notifications.TemplateUserAccountDeleted, notifyEnq.Sent[1].TemplateID) |
There was a problem hiding this comment.
Should the owner receive an email for their own action?
We're suppressing this for users who delete their own workspaces, for example, so I wonder if we should follow the same pattern. Possible follow-up though, non-blocking.
There was a problem hiding this comment.
You can't delete your own account, so I believe there is no need to filter.
There was a problem hiding this comment.
What i mean is: if an owner initiated an event - they should probably not receive a notification about it because it's redundant.
There was a problem hiding this comment.
I understand that they won't receive as the API method will fail faster? see code
There was a problem hiding this comment.
Oh.. you mean the owner of the action.. not the owner of the account. Interesting case, on the other hand, if somebody took over the account, notifications would work like auditing.
Related: coder/internal#17
This PR extends
api.deleteUserto notify owners and user admins when somebody deletes a new user.