Skip to content

fix: flake in setup-docker in release #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2022
Merged

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented May 12, 2022

During a release, the setup-docker sometimes flakes on the latest version. See docker-practice/actions-setup-docker#18

@bpmct bpmct self-assigned this May 12, 2022
@bpmct bpmct requested a review from dwahler May 12, 2022 20:23
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #1412 (dba4fb9) into main (9ef64fd) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1412      +/-   ##
==========================================
+ Coverage   67.23%   67.33%   +0.09%     
==========================================
  Files         287      287              
  Lines       19210    19210              
  Branches      241      241              
==========================================
+ Hits        12916    12935      +19     
+ Misses       4963     4948      -15     
+ Partials     1331     1327       -4     
Flag Coverage Δ
unittest-go-macos-latest 54.19% <ø> (+0.05%) ⬆️
unittest-go-postgres- 65.82% <ø> (+0.15%) ⬆️
unittest-go-ubuntu-latest 56.72% <ø> (+0.05%) ⬆️
unittest-go-windows-2022 52.67% <ø> (+0.12%) ⬆️
unittest-js 74.65% <ø> (ø)
Impacted Files Coverage Δ
peerbroker/dial.go 83.60% <0.00%> (-6.56%) ⬇️
peerbroker/listen.go 84.03% <0.00%> (-3.37%) ⬇️
provisionerd/provisionerd.go 76.97% <0.00%> (-0.14%) ⬇️
provisioner/terraform/provision.go 72.30% <0.00%> (+0.40%) ⬆️
coderd/provisionerdaemons.go 63.81% <0.00%> (+0.50%) ⬆️
peer/conn.go 82.80% <0.00%> (+3.93%) ⬆️
peer/channel.go 88.30% <0.00%> (+4.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ef64fd...dba4fb9. Read the comment docs.

@bpmct bpmct merged commit 75a5877 into main May 12, 2022
@bpmct bpmct deleted the bpmct/fix-docker-release-flake branch May 12, 2022 20:44
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants