Skip to content

chore: use pnpm workspaces #14126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

chore: use pnpm workspaces #14126

wants to merge 7 commits into from

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Aug 2, 2024

Been meaning to do this for a long time :^)

@aslilac aslilac requested review from a team and BrunoQuaresma and removed request for a team August 2, 2024 17:05
@aslilac
Copy link
Member Author

aslilac commented Aug 2, 2024

ok, turns out this isn't gonna be the easy slam dunk that I thought it would 🙃

@aslilac aslilac marked this pull request as draft August 2, 2024 18:26
@BrunoQuaresma
Copy link
Collaborator

Which blockers are you finding?

@aslilac
Copy link
Member Author

aslilac commented Aug 2, 2024

seems like the lock file didn't merge very cleanly, so a lot of versions are messed up, and it's causing tons of errors :\

@BrunoQuaresma
Copy link
Collaborator

Maybe related to my fix #14134

@matifali
Copy link
Member

matifali commented Aug 8, 2024

If this transition is successful we can list Coder on this page https://pnpm.io/workspaces#usage-examples. ⭐

@aslilac
Copy link
Member Author

aslilac commented Aug 8, 2024

I'm struggling to get it to merge the lock files into a single workspace lock file properly. :(

@github-actions github-actions bot added the stale This issue is like stale bread. label Aug 16, 2024
@github-actions github-actions bot closed this Aug 19, 2024
@github-actions github-actions bot deleted the pnpm-fixup branch February 9, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale This issue is like stale bread.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants