Skip to content

chore: skip audit log filter for owner/admin users #14132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Aug 2, 2024

Optimize for speed in the case the user can read all audit_logs.
We might be able to add an index later to speed this up, but for legacy cases (when only owners/auditor could view), let's not slow things down.

Screencast.from.2024-08-02.13-13-24.webm

Optimize for speed in the case the user can read all audit_logs
@Emyrk Emyrk changed the title chore: audit log filter to be skipped if user is owner/admin chore: skip audit log filter for owner/admin users Aug 2, 2024
@Emyrk Emyrk requested a review from f0ssel August 2, 2024 19:14
Copy link
Contributor

@f0ssel f0ssel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Emyrk Emyrk merged commit a77a9ab into main Aug 5, 2024
30 checks passed
@Emyrk Emyrk deleted the stevenmasley/quicker_audit_logs branch August 5, 2024 18:42
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants