Skip to content

chore: remove global organization id state #14135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 5, 2024
Merged

chore: remove global organization id state #14135

merged 12 commits into from
Aug 5, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Aug 2, 2024

Closes #14057

  • Removes organizationId from the dashboard provider
  • Cleans up some more navigation code
  • Shows templates from all organizations on /templates now
  • Fix some bugs around creating and viewing workspaces, all related to using the wrong organization ID

@aslilac aslilac requested review from a team and jaaydenh and removed request for a team August 2, 2024 18:26
Copy link

alwaysmeticulous bot commented Aug 2, 2024

🤖 Meticulous spotted visual differences in 458 of 944 screens tested: view and approve differences detected.

Last updated for commit f7879a1. This comment will update as new commits are pushed.

@aslilac aslilac requested review from a team and BrunoQuaresma August 2, 2024 22:25
dashboard.experiments.includes("multi-organization") &&
selectFeatureVisibility(dashboard.entitlements).multiple_organizations;

return hasMultipleOrganizations || organizationsEnabled
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the deployment has multiple organizations. but the organization's feature is not enabled, should this return true? The use case I'm seeing is a deployment that had access to enterprise and does not have it anymore after the trial.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's the goal. We don't want swaths of the app to become unaccessible because they're in the final stages of renewing a contract with us.

Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, and I think we have good coverage around the affected components. I'm approving it, and I will run a quick check afterward.

@BrunoQuaresma
Copy link
Collaborator

BrunoQuaresma commented Aug 5, 2024

To run this in the new workspace version after upgrading to NodeJS 20+, we have to rebase this branch with main, but I will leave this up to you since I don't want to disrupt your flow.

@aslilac aslilac merged commit efbd625 into main Aug 5, 2024
30 checks passed
@aslilac aslilac deleted the korgpolish branch August 5, 2024 16:34
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot view workspaces in another organization
2 participants