Skip to content

chore: delete user codersdk to support status code regression #14173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2024
Merged

chore: delete user codersdk to support status code regression #14173

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
592d444
chore: delete user codersdk to support status code regression
Emyrk Aug 5, 2024
5926e7b
Update codersdk/users.go
Emyrk Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update codersdk/users.go 
Co-authored-by: Kayla Washburn-Love <mckayla@hey.com>
  • Loading branch information
@Emyrk @aslilac
Emyrk and aslilac authored Aug 7, 2024
commit 5926e7bd85d89fc4774355bb6285571c17d94b36
6 changes: 2 additions & 4 deletions codersdk/users.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,10 +309,8 @@ func (c *Client) DeleteUser(ctx context.Context, id uuid.UUID) error {
return err
}
defer res.Body.Close()
// Check for both status codes, there was a release that changed this response
// to StatusNoContent. To be compatible with that, the second condition is
// included.
// The 'http.StatusNoContent' check can be removed in 2025
// Check for a 200 or a 204 response. 2.14.0 accidentally included a 204 response,
// which was a breaking change, and reverted in 2.14.1.
if res.StatusCode != http.StatusOK && res.StatusCode != http.StatusNoContent {
return ReadBodyAsError(res)
}
Expand Down
Loading