Skip to content

chore(agent): remove err=<nil> log for batch update metadata complete #14179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 7, 2024
Merged

chore(agent): remove err=<nil> log for batch update metadata complete #14179

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
78ee6e0
agent: skip err=<nil> log for batch update metadata complete
mafredri Aug 6, 2024
40c77ea
Update agent/agent.go
mafredri Aug 6, 2024
1038ec5
Update agent/agent.go
mafredri Aug 6, 2024
d494051
Update agent/agent.go
mafredri Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion agent/agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,10 +588,12 @@
updatedMetadata[mr.key] = mr.result
continue
case err := <-reportError:
a.logger.Debug(ctx, "batch update metadata complete", slog.Error(err))
logMsg := ""batch update metadata complete""

Check failure on line 591 in agent/agent.go

View workflow job for this annotation

GitHub Actions / fmt 

expected ';', found batch

Check failure on line 591 in agent/agent.go

View workflow job for this annotation

GitHub Actions / test-go (ubuntu-latest) 

syntax error: unexpected batch at end of statement

Check failure on line 591 in agent/agent.go

View workflow job for this annotation

GitHub Actions / test-go-pg 

syntax error: unexpected batch at end of statement

Check failure on line 591 in agent/agent.go

View workflow job for this annotation

GitHub Actions / test-go-pg-16 

syntax error: unexpected batch at end of statement

Check failure on line 591 in agent/agent.go

View workflow job for this annotation

GitHub Actions / test-go (macos-latest) 

syntax error: unexpected batch at end of statement

Check failure on line 591 in agent/agent.go

View workflow job for this annotation

GitHub Actions / test-go (windows-2022) 

syntax error: unexpected batch at end of statement

Check failure on line 591 in agent/agent.go

View workflow job for this annotation

GitHub Actions / test-go (windows-2022) 

syntax error: unexpected batch at end of statement

Check failure on line 591 in agent/agent.go

View workflow job for this annotation

GitHub Actions / test-go-race 

syntax error: unexpected batch at end of statement
if err != nil {
a.logger.Debug(ctx, logMsg, slog.Error(err))
return xerrors.Errorf("failed to report metadata: %w", err)
}
a.logger.Debug(ctx, logMsg)
reportInFlight = false
case <-report:
if len(updatedMetadata) == 0 {
Expand Down
Loading