fix: allow group members to read group information#14200

Merged

Emyrk merged 24 commits intocoder:mainfrom

hugodutka:hugodutka/13988-group-member-read-permissions

Aug 13, 2024

Commits on Aug 12, 2024

- allow group members to read basic Group info
hugodutka
committed
rename ReducedGroup.member_count to ReducedGroup.total_member_count
hugodutka
committed
use the reduced groups for user endpoint on the AccountPage
hugodutka
committed
rename UserWithGroupAndOrgID to GroupMemberRBACHelper
hugodutka
committed
add the group_members_expanded db view
hugodutka
committed
add comment on migration
hugodutka
committed
rewrite group member queries to use the group_members_expanded view
hugodutka
committed
add the RBAC ResourceGroupMember and add it to relevant roles
hugodutka
committed
rewrite GetGroupMembersByGroupID permission checks
hugodutka
committed
- make the GroupMember type contain all user fields
hugodutka
committed
simplify RBAC check on group member count
hugodutka
committed
add the MemberTotalCount field to codersdk.Group
hugodutka
committed
remove the reduced groups endpoint, revert frontend to use the groups by org endpoint
hugodutka
committed
revert "simplify RBAC check on group member count" - new query didn't work on empty groups
hugodutka
committed
display `group.total_member_count` instead of `group.members.length` on the account page
hugodutka
committed
adjust `total_member_count` on `MockGroup`
hugodutka
committed
fixes after rebase
hugodutka
committed
simplify RBAC check on GetGroupMembersCountByGroupID
hugodutka
committed
fix tests
hugodutka
committed
resolve lint error
hugodutka
committed
update the groupsauth test to work with new group member permissions
hugodutka
committed
fix a mistake in test
hugodutka
committed

Commits on Aug 13, 2024

make ErrUserDeleted private
hugodutka
committed
`dbgen.GroupMember` now fails when a supplied user or group doesn't exist
hugodutka
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: allow group members to read group information#14200

fix: allow group members to read group information#14200
Emyrk merged 24 commits intocoder:mainfrom
hugodutka:hugodutka/13988-group-member-read-permissions

Commits on Aug 12, 2024

- allow group members to read basic Group info

rename ReducedGroup.member_count to ReducedGroup.total_member_count

use the reduced groups for user endpoint on the AccountPage

rename UserWithGroupAndOrgID to GroupMemberRBACHelper

add the group_members_expanded db view

add comment on migration

rewrite group member queries to use the group_members_expanded view

add the RBAC ResourceGroupMember and add it to relevant roles

rewrite GetGroupMembersByGroupID permission checks

- make the GroupMember type contain all user fields

simplify RBAC check on group member count

add the MemberTotalCount field to codersdk.Group

remove the reduced groups endpoint, revert frontend to use the groups by org endpoint

revert "simplify RBAC check on group member count" - new query didn't work on empty groups

display `group.total_member_count` instead of `group.members.length` on the account page

adjust `total_member_count` on `MockGroup`

fixes after rebase

simplify RBAC check on GetGroupMembersCountByGroupID

fix tests

resolve lint error

update the groupsauth test to work with new group member permissions

fix a mistake in test

Commits on Aug 13, 2024

make ErrUserDeleted private

`dbgen.GroupMember` now fails when a supplied user or group doesn't exist

fix: allow group members to read group information#14200Emyrk merged 24 commits intocoder:maincoder/coder:mainfrom hugodutka:hugodutka/13988-group-member-read-permissionshugodutka/coder:hugodutka/13988-group-member-read-permissionsCopy head branch name to clipboard

Commits

Commits on Aug 12, 2024

Commits on Aug 13, 2024

fix: allow group members to read group information#14200
Emyrk merged 24 commits intocoder:mainfrom
hugodutka:hugodutka/13988-group-member-read-permissions