Skip to content

fix: add version information to default docs links #14205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 9, 2024
Merged

fix: add version information to default docs links #14205

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e918d62
init
bcpeinhardt Aug 7, 2024
499f4d3
re-extract isValidDocsUrl for clarity
bcpeinhardt Aug 7, 2024
d573e10
only add version info to default url
bcpeinhardt Aug 7, 2024
be2a76c
Update site/src/utils/docs.ts
bcpeinhardt Aug 8, 2024
52d60dc
refactor slightly
bcpeinhardt Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
re-extract isValidDocsUrl for clarity
  • Loading branch information
@bcpeinhardt
bcpeinhardt committed Aug 7, 2024
commit 499f4d351d483b50f6527b744ec1256de54fecf5
3 changes: 2 additions & 1 deletion site/src/utils/docs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ const getBaseDocsURL = () => {
.querySelector<HTMLMetaElement>('meta[property="docs-url"]')
?.getAttribute("content");

CACHED_DOCS_URL = docsUrl && isURL(docsUrl) ? docsUrl : DEFAULT_DOCS_URL;
const isValidDocsURL = docsUrl && isURL(docsUrl);
CACHED_DOCS_URL = isValidDocsURL ? docsUrl : DEFAULT_DOCS_URL;

// If we can get the specific version, we want to include that in docs links
const version = getStaticBuildInfo()?.version.split("-")[0];
Expand Down