Skip to content

fix: patch known issues in 2.14.1 #14207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2024
Merged

fix: patch known issues in 2.14.1 #14207

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66a7845
chore: revert status code change for delete users endpoint (#14168)
Emyrk Aug 5, 2024
d1ea34f
chore: delete user codersdk to support status code regression (#14173)
Emyrk Aug 7, 2024
5bd4f1b
fix: add template editor to /templates/:templateName route group (#14…
aslilac Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: delete user codersdk to support status code regression (#14173) 
* chore: delete user codersdk to support status code regression
* Update codersdk/users.go

Co-authored-by: Kayla Washburn-Love <mckayla@hey.com>

---------

Co-authored-by: Kayla Washburn-Love <mckayla@hey.com>
(cherry picked from commit b55a7a8)
  • Loading branch information
@Emyrk @aslilac @stirby
2 people authored and stirby committed Aug 7, 2024
commit d1ea34ff102ea14d98395ce5fb72c9f076d32d35
4 changes: 3 additions & 1 deletion codersdk/users.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,9 @@ func (c *Client) DeleteUser(ctx context.Context, id uuid.UUID) error {
return err
}
defer res.Body.Close()
if res.StatusCode != http.StatusOK {
// Check for a 200 or a 204 response. 2.14.0 accidentally included a 204 response,
// which was a breaking change, and reverted in 2.14.1.
if res.StatusCode != http.StatusOK && res.StatusCode != http.StatusNoContent {
return ReadBodyAsError(res)
}
return nil
Expand Down