Skip to content

refactor: refactor notification email templates #14208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 9, 2024
Merged

refactor: refactor notification email templates #14208

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
898014c
Update template email
BrunoQuaresma Aug 7, 2024
a17381f
Pass extra data to template
BrunoQuaresma Aug 7, 2024
0d347fc
Add dark mode
BrunoQuaresma Aug 7, 2024
ec17ad5
Update colors
BrunoQuaresma Aug 7, 2024
3270cd5
Simplify passing data
BrunoQuaresma Aug 7, 2024
bfbf974
Fix data passing
BrunoQuaresma Aug 8, 2024
9ebdb6f
Fix test
BrunoQuaresma Aug 9, 2024
79ee99e
Use horizontal logo
BrunoQuaresma Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Aug 9, 2024
commit 9ebdb6f8d7ac436a9b165d88de022dcede01e3d1
7 changes: 5 additions & 2 deletions coderd/notifications/dispatch/smtp_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (
"net"
"sync"
"testing"
"text/template"

"github.com/emersion/go-sasl"
"github.com/emersion/go-smtp"
Expand Down Expand Up @@ -418,7 +417,11 @@ func TestSMTP(t *testing.T) {
require.NoError(t, hp.Set(listen.Addr().String()))
tc.cfg.Smarthost = hp

handler := dispatch.NewSMTPHandler(tc.cfg, template.FuncMap{}, logger.Named("smtp"))
helpers := map[string]any{
"base_url": func() string { return "http://test.com" },
"current_year": func() string { return "2024" },
}
handler := dispatch.NewSMTPHandler(tc.cfg, helpers, logger.Named("smtp"))

// Start mock SMTP server in the background.
var wg sync.WaitGroup
Expand Down