feat: show summary if unable to edit org #14214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Meticulous spotted visual differences in 16 of 1313 screens tested: view and approve differences detected. Last updated for commit 920b210. This comment will update as new commits are pushed. |
ae276c4 to
9099d34
Compare
9099d34 to
933f61f
Compare
933f61f to
365bc1d
Compare
aslilac
reviewed
Aug 7, 2024
site/src/pages/ManagementSettingsPage/OrganizationSettingsPage.test.tsx
Outdated
Show resolved
Hide resolved
site/src/pages/ManagementSettingsPage/OrganizationSummaryPageView.tsx
Outdated
Show resolved
Hide resolved
1b43214 to
84176cd
Compare
aslilac
reviewed
Aug 9, 2024
site/src/pages/ManagementSettingsPage/OrganizationSettingsPage.tsx
Outdated
Show resolved
Hide resolved
|
oh, is graphite having some issue with stacking? just noticed all the merge conflict warnings, so my comments are probably out of date |
This can happen if you can edit the members, for example, but not the organization settings. In this case you will see a new summary page instead of the edit form.
84176cd to
7f520e7
Compare
Oh yeah sorry about that, I am not using Graphite so I had not pushed up a rebase yet. Sorry for the noise |
aslilac
approved these changes
Aug 9, 2024
214c5f7 to
e3ac9a2
Compare
e3ac9a2 to
920b210
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen if you can edit the members, for example, but not the organization settings. In this case you will see a new summary page instead of the edit form.
Stacked on #14193
It looks kinda lame, honestly, but probably less bad than an ineditable form, I think. Happy to take this in a different direction if we have some nicer-looking ideas.