Skip to content

test: add unit test to verify group permission behavior #14223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 12, 2024
Merged

test: add unit test to verify group permission behavior #14223

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a42e77c
test: add unit test to verify group permission behavior
Emyrk Aug 9, 2024
0b9711e
fmt
Emyrk Aug 9, 2024
e14728e
Update coderd/database/dbauthz/groupsauth_test.go
Emyrk Aug 12, 2024
80bbcac
pre suggestions
Emyrk Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
pre suggestions
  • Loading branch information
@Emyrk
Emyrk committed Aug 12, 2024
commit 80bbcac4e8463445df6802c40fe5a59e875001dd
4 changes: 3 additions & 1 deletion coderd/database/dbauthz/groupsauth_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"testing"

"github.com/google/uuid"
"github.com/prometheus/client_golang/prometheus"
"github.com/stretchr/testify/require"

Expand Down Expand Up @@ -132,7 +133,7 @@ func TestGroupsAuth(t *testing.T) {
Name: "DifferentOrgAdmin",
Subject: rbac.Subject{
ID: "orgadmin",
Roles: rbac.Roles(must(rbac.RoleIdentifiers{}.Expand())),
Roles: rbac.Roles(must(rbac.RoleIdentifiers{rbac.ScopedRoleOrgUserAdmin(uuid.New())}.Expand())),
Groups: []string{},
Scope: rbac.ExpandableScope(rbac.ScopeAll),
},
Expand Down Expand Up @@ -160,6 +161,7 @@ func TestGroupsAuth(t *testing.T) {
require.Len(t, members, tc.MembersExpected, "member count found does not match")
} else {
require.Error(t, err, "member read")
require.True(t, dbauthz.IsNotAuthorizedError(err), "not authorized error")
}
})
}
Expand Down
Loading