feat: add delete custom role context menu button and modal #14228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jaaydenh
commented
Aug 9, 2024
•
- Add edit button to row options context menu to edit role instead of clicking the row
- Add delete context menu button to display delete modal
- Custom Role Delete modal
- Delete mutation to delete role
|
🤖 Meticulous spotted visual differences in 53 of 1313 screens tested: view and approve differences detected. Last updated for commit 84524d0. This comment will update as new commits are pushed. |
aslilac
approved these changes
Aug 9, 2024
| @@ -601,20 +601,20 @@ class ApiMethods { | |||
| }; | |||
|
|
|||
| patchOrganizationRole = async ( | |||
| organizationId: string, | |||
| organization: string, | |||
There was a problem hiding this comment.
can you copy-paste the doc comment a lot of these other org functions have? it's a minor thing, but I like the easily accessible reassurance that it can be the id or the name 😄
| role, | ||
| ); | ||
|
|
||
| return response.data; | ||
| }; | ||
|
|
||
| deleteOrganizationRole = async (organizationId: string, roleName: string) => { | ||
| deleteOrganizationRole = async (organization: string, roleName: string) => { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.