Skip to content

fix(site): correct user agent data on audit row #14243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

BrunoQuaresma
Copy link
Collaborator

Fix #13896

@BrunoQuaresma BrunoQuaresma requested a review from a team August 12, 2024 17:04
@BrunoQuaresma BrunoQuaresma self-assigned this Aug 12, 2024
@BrunoQuaresma BrunoQuaresma requested review from bcpeinhardt and removed request for a team August 12, 2024 17:04
Copy link
Contributor

@bcpeinhardt bcpeinhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me :)

I'm not surprised you were getting weird results for a blank string passed to the user agent parser. User agent parsers might as well be magic 8 balls.

@BrunoQuaresma BrunoQuaresma changed the title fix(site): fix user agent data on audit row fix(site): correct user agent data on audit row Aug 13, 2024
@BrunoQuaresma BrunoQuaresma merged commit 712a1b5 into main Aug 13, 2024
33 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-audit-browser-data branch August 13, 2024 17:02
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit page on dashboard incorrectly shows OS & Browser for autodelete logs
2 participants