fix: use insert and delete instead of upsert for custom roles #14252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14da05a to
c567a9d
Compare
ffa67cf to
7042119
Compare
aslilac
approved these changes
Aug 13, 2024
Comment on lines
59
to
65
| if (role) { | ||
| await updateOrganizationRoleMutation.mutateAsync(data); | ||
| navigate(`/organizations/${organizationName}/roles`); | ||
| } else { | ||
| await createOrganizationRoleMutation.mutateAsync(data); | ||
| navigate(`/organizations/${organizationName}/roles`); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (role) { | |
| await updateOrganizationRoleMutation.mutateAsync(data); | |
| navigate(`/organizations/${organizationName}/roles`); | |
| } else { | |
| await createOrganizationRoleMutation.mutateAsync(data); | |
| navigate(`/organizations/${organizationName}/roles`); | |
| } | |
| if (role) { | |
| await updateOrganizationRoleMutation.mutateAsync(data); | |
| } else { | |
| await createOrganizationRoleMutation.mutateAsync(data); | |
| } | |
| navigate(`/organizations/${organizationName}/roles`); |
|
🤖 Meticulous replayed 100 user sessions and took 1355 visual snapshots. Meticulous has not yet run on c567a9d of the main branch and so there was nothing to compare against. Last updated for commit 161ee26. This comment will update as new commits are pushed. |
05f1814
into
stevenmasley/custom_role_remove_upsert
30 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #14245