Skip to content

chore: update envbox template image #14256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 14, 2024
Merged

chore: update envbox template image #14256

merged 3 commits into from
Aug 14, 2024

Conversation

cjlarose
Copy link
Contributor

@cjlarose cjlarose commented Aug 13, 2024 •
edited
Loading

Updated installation of code-server to be consistent with the other templates using the same method as #6138

This fixes an error where the stderr stream of code-server wasn't correctly redirected to the log file

Screenshot 2024-08-12 at 23 41 05

WARNING: script exited successfully, but output pipes were not closed after 10s. This usually means a child process was started with references to stdout or stderr. As a result, this process may now have been terminated. Consider redirecting the output or using a separate "coder_script" for the process, see https://coder.com/docs/templates/troubleshooting#startup-script-issues for more information.

Also updated the image used in the "inner container" of the envbox template and removed unnecessary sensitive designation on template variables.

I tested the new template to verify it creates a workspace without error. I verified that systemd and docker appear to be working normally in the workspace.

@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Aug 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 13, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@cjlarose
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

cdrcommunity added a commit to coder/cla that referenced this pull request Aug 13, 2024
@cdrcommunity
@cjlarose has signed the CLA in coder/coder#14256
9070fdf
@cjlarose cjlarose changed the title Update envbox template chore: Update envbox template image Aug 13, 2024
@cjlarose cjlarose changed the title chore: Update envbox template image chore: update envbox template image Aug 13, 2024
@cjlarose
chore: update inner image in envbox example template
d77eb70 
The referenced image seems to be a deprecated version of the enterprise-base image
@cjlarose
chore: update install of code-server in envbox template
3a6f5a8 
Update the installation to match the other templates, in particular:

* Install using standalone method
* Install to /tmp
* Close parent stderr stream (write code-server stderr to log file)
@cjlarose
chore: remove sensitive designation on non-sensitive variables
d90fb01
@cjlarose cjlarose force-pushed the update-envbox-template branch from 68ae389 to d90fb01 Compare August 13, 2024 06:56
@matifali matifali requested review from sreya and deansheather August 13, 2024 08:28
@deansheather
Copy link
Member

Tested on dev.coder.com and it works fine.

@deansheather deansheather merged commit 86b9c97 into coder:main Aug 14, 2024
27 checks passed
@deansheather
Copy link
Member

Thank you for your contribution! 🚀

@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

@sreya sreya Awaiting requested review from sreya

Assignees

@cjlarose cjlarose

Labels
community Pull Requests and issues created by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjlarose @deansheather