Skip to content

fix: use authenticated urls for pubsub #14261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Aug 26, 2024
Merged

fix: use authenticated urls for pubsub #14261

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
b89ff23
fix: use authenticated urls for pubsub
f0ssel Aug 13, 2024
88d50b8
comments
f0ssel Aug 13, 2024
8be0524
flake
f0ssel Aug 13, 2024
3be05c2
fmt
f0ssel Aug 13, 2024
c7964e4
temp add personal fork
f0ssel Aug 13, 2024
6ff2ec7
update coder fork
f0ssel Aug 14, 2024
02258ee
test pubsub
f0ssel Aug 14, 2024
9d8681b
test pubsub
f0ssel Aug 14, 2024
85f6cfe
t log
f0ssel Aug 14, 2024
dae69c7
add customer driver tests
f0ssel Aug 21, 2024
55df464
merge main
f0ssel Aug 21, 2024
2019fec
update flake
f0ssel Aug 21, 2024
ff2784c
lint
f0ssel Aug 21, 2024
c18963b
move to defer
f0ssel Aug 21, 2024
1600abf
fix tests
f0ssel Aug 22, 2024
839a52e
remove log
f0ssel Aug 22, 2024
428f3f5
merge main
f0ssel Aug 22, 2024
cd61cc7
update flake
f0ssel Aug 22, 2024
c946cdd
fmt
f0ssel Aug 22, 2024
1b139e4
close chan
f0ssel Aug 22, 2024
8c96f6e
use pq
f0ssel Aug 23, 2024
a645a76
merge main
f0ssel Aug 23, 2024
ed009f7
update flake
f0ssel Aug 23, 2024
c8a7c9a
fix flake
f0ssel Aug 23, 2024
05cbc3c
sleep to prevent flake
f0ssel Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
sleep to prevent flake
  • Loading branch information
@f0ssel
f0ssel committed Aug 26, 2024
commit 05cbc3c903a1bb10cf6fc3ca6d562c775c4f649e
4 changes: 4 additions & 0 deletions coderd/database/pubsub/pubsub_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"database/sql"
"testing"
"time"

"github.com/prometheus/client_golang/prometheus"
"github.com/stretchr/testify/assert"
Expand Down Expand Up @@ -179,6 +180,9 @@ func TestPGPubsubDriver(t *testing.T) {

// wait for the reconnect
_ = testutil.RequireRecvCtx(ctx, t, subDriver.Connections)
// we need to sleep because the raw connection notification
// is sent before the pq.Listener can reestablish it's listeners
time.Sleep(1 * time.Second)

// ensure our old subscription still fires
err = pubber.Publish("test", []byte("hello-again"))
Expand Down
Loading