Skip to content

fix: remove account description #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2022
Merged

fix: remove account description #1427

merged 2 commits into from
May 13, 2022

Conversation

greyscaled
Copy link
Contributor

Resolves: #1419

@greyscaled greyscaled requested a review from a team as a code owner May 13, 2022 15:33
@greyscaled greyscaled enabled auto-merge (squash) May 13, 2022 15:34
@greyscaled greyscaled disabled auto-merge May 13, 2022 15:35
@codecov
Copy link

codecov bot commented May 13, 2022 •
edited
Loading

Codecov Report

Merging #1427 (8c9b9e1) into main (e6168ba) will increase coverage by 8.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1427      +/-   ##
==========================================
+ Coverage   58.80%   67.22%   +8.42%     
==========================================
  Files         287      287              
  Lines       19331    19331              
  Branches      244      244              
==========================================
+ Hits        11367    12996    +1629     
+ Misses       6747     4997    -1750     
- Partials     1217     1338     +121
Flag Coverage Δ
unittest-go-macos-latest 54.18% <ø> (+0.01%) ⬆️
unittest-go-postgres- 65.58% <ø> (?)
unittest-go-ubuntu-latest 56.60% <ø> (-0.02%) ⬇️
unittest-go-windows-2022 52.54% <ø> (-0.05%) ⬇️
unittest-js 75.26% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
...pages/PreferencesPages/AccountPage/AccountPage.tsx 89.47% <ø> (ø)
site/src/components/Section/Section.tsx 61.11% <0.00%> (-5.56%) ⬇️
coderd/provisionerdaemons.go 63.31% <0.00%> (+0.50%) ⬆️
coderd/workspaceagents.go 56.04% <0.00%> (+0.69%) ⬆️
provisionerd/provisionerd.go 76.57% <0.00%> (+0.80%) ⬆️
agent/agent.go 67.14% <0.00%> (+1.23%) ⬆️
coderd/templates.go 64.24% <0.00%> (+1.55%) ⬆️
provisioner/echo/serve.go 56.80% <0.00%> (+2.39%) ⬆️
peer/conn.go 80.83% <0.00%> (+2.70%) ⬆️
cli/server.go 58.08% <0.00%> (+3.53%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6168ba...8c9b9e1. Read the comment docs.

@greyscaled greyscaled changed the title fix: account copy fix: remove account description May 13, 2022
@greyscaled greyscaled merged commit 89e44da into main May 13, 2022
@greyscaled greyscaled deleted the vapurrmaid/1419/account-copy branch May 13, 2022 15:53
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@greyscaled @kylecarbs
fix: remove account description (#1427)
781a306 
Resolves: #1419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs left review comments

@presleyp presleyp presleyp approved these changes

@Kira-Pilot Kira-Pilot Kira-Pilot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

Account Settings incorrectly states you can update your display name
5 participants
@greyscaled @presleyp @kylecarbs @Kira-Pilot @misskniss