Skip to content

chore: fixup quotas to only include groups you are a member of #14271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 15, 2024

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Aug 14, 2024

Before all everyone groups were included in the allowance. Using the new expanded group member view to have a consistent "group membership" rule. Rather then doing the org membership manually in each query.

Before all everyone groups were included in the allowance.
@Emyrk Emyrk requested a review from code-asher August 14, 2024 21:06
@Emyrk
Copy link
Member Author

Emyrk commented Aug 15, 2024

Discovered there exists deployments with rows in the Everyone groups. Added a test: c85052b

@Emyrk Emyrk merged commit 83ccdaa into main Aug 15, 2024
27 checks passed
@Emyrk Emyrk deleted the stevenmasley/fixup_global_quota_query branch August 15, 2024 18:27
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants