Fixing tests

Signed-off-by: Danny Kopping <danny@coder.com>
coder · dannykopping · Aug 21, 2024 · Aug 7, 2024 · Aug 13, 2024 · Aug 13, 2024
commit 28fa2f7868dd651bc1510b6bf23c339e34b74020
diff --git a/coderd/database/dbauthz/dbauthz_test.go b/coderd/database/dbauthz/dbauthz_test.go
@@ -2463,6 +2463,13 @@ func (s *MethodTestSuite) TestSystemFunctions() {
 			JobID: j.ID,
 		}).Asserts( /*rbac.ResourceSystem, policy.ActionCreate*/ )
 	}))
+	s.Run("InsertProvisionerJobTimings", s.Subtest(func(db database.Store, check *expects) {
+		// TODO: we need to create a ProvisionerJob resource
+		j := dbgen.ProvisionerJob(s.T(), db, nil, database.ProvisionerJob{})
+		check.Args(database.InsertProvisionerJobTimingsParams{
+			JobID: j.ID,
+		}).Asserts( /*rbac.ResourceSystem, policy.ActionCreate*/ )
+	}))
 	s.Run("UpsertProvisionerDaemon", s.Subtest(func(db database.Store, check *expects) {
 		org := dbgen.Organization(s.T(), db, database.Organization{})
 		pd := rbac.ResourceProvisionerDaemon.InOrg(org.ID)

diff --git a/coderd/workspacebuilds.go b/coderd/workspacebuilds.go
@@ -1011,21 +1011,3 @@ func convertWorkspaceStatus(jobStatus codersdk.ProvisionerJobStatus, transition
 	// return error status since we should never get here
 	return codersdk.WorkspaceStatusFailed
 }
-
-func convertWorkspaceBuildStats(stats database.ProvisionerJobStat) codersdk.WorkspaceBuildStats {
-	return codersdk.WorkspaceBuildStats{
-		ID:             stats.JobID,
-		JobStatus:      codersdk.ProvisionerJobStatus(stats.JobStatus),
-		WorkerID:       stats.WorkspaceID,
-		WorkspaceID:    stats.WorkspaceID,
-		Error:          stats.Error.String,
-		ErrorCode:      stats.ErrorCode.String,
-		UpdatedAt:      stats.UpdatedAt,
-		QueuedSecs:     stats.QueuedSecs,
-		CompletionSecs: stats.CompletionSecs,
-		CanceledSecs:   stats.CanceledSecs,
-		InitSecs:       stats.InitSecs,
-		PlanSecs:       stats.PlanSecs,
-		ApplySecs:      stats.ApplySecs,
-	}
-}
diff --git a/provisioner/terraform/timings_test.go b/provisioner/terraform/timings_test.go
@@ -18,6 +18,8 @@
 // This log content is then used to usher the provisioning process along as if terraform has run, and consequently
 // the timing data is extracted from the log content and validated against the expected values.
 func TestTimingsFromProvision(t *testing.T) {
+	t.Parallel()
+
 	cwd, err := os.Getwd()
 	require.NoError(t, err)
 
@@ -26,11 +28,11 @@

 	t.Logf(fakeBin)

 	ctx, api := setupProvisioner(t, &provisionerServeOptions{
 		binaryPath: fakeBin,
 	})
 	sess := configure(ctx, t, api, &proto.Config{
 		TemplateSourceArchive: makeTar(t, nil),
 	})

 	ctx, cancel := context.WithTimeout(ctx, testutil.WaitLong)
@@ -38,7 +40,7 @@

 	// When: a plan is executed in the provisioner, our fake terraform will be executed and will produce a
 	// state file and some log content.
 	err = sendPlan(sess, proto.WorkspaceTransition_START)
 	require.NoError(t, err)

 	var timings []*proto.Timing
@@ -65,7 +67,7 @@
 	}

 	// When: the plan has completed, let's trigger an apply.
 	err = sendApply(sess, proto.WorkspaceTransition_START)
 	require.NoError(t, err)

 	for {

diff --git a/site/e2e/google/protobuf/timestampGenerated.ts b/site/e2e/google/protobuf/timestampGenerated.ts