Skip to content

chore(envbuilder-dogfood): update envbuilder-dogfood template to use provider #14324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 20, 2024
Merged

chore(envbuilder-dogfood): update envbuilder-dogfood template to use provider #14324

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b0cb5f
update envbuider-dogfood template to use provider
johnstcn Aug 16, 2024
3b24e0e
make fmt
johnstcn Aug 16, 2024
8de7b3f
comment out unnecessary environment variables
johnstcn Aug 16, 2024
1695823
Apply suggestions from code review
johnstcn Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review 
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
  • Loading branch information
@johnstcn @mafredri
johnstcn and mafredri authored Aug 20, 2024
commit 16958232c11cb757f44fce9470d86bbb97602033
4 changes: 2 additions & 2 deletions envbuilder-dogfood/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,12 +345,12 @@ locals {
"CODER_AGENT_TOKEN" : coder_agent.dev.token,
"CODER_AGENT_URL" : data.coder_workspace.me.access_url,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose these could be set on the container only, but fine to keep here for convenience 👍🏻

"ENVBUILDER_GIT_USERNAME" : data.coder_external_auth.github.access_token,
# "ENVBUILDER_GIT_URL" : data.coder_parameter.devcontainer_repo.value, # This is set automatically by the provider.
# "ENVBUILDER_GIT_URL" : data.coder_parameter.devcontainer_repo.value, # The provider sets this via the `git_url` property.
"ENVBUILDER_DEVCONTAINER_DIR" : data.coder_parameter.devcontainer_dir.value,
"ENVBUILDER_INIT_SCRIPT" : coder_agent.dev.init_script,
"ENVBUILDER_FALLBACK_IMAGE" : "codercom/oss-dogfood:latest", # This image runs if builds fail
"ENVBUILDER_PUSH_IMAGE" : "true", # Push the image to the remote cache
# "ENVBUILDER_CACHE_REPO" : local.cache_repo, # This is set automatically by the provider.
# "ENVBUILDER_CACHE_REPO" : local.cache_repo, # The provider sets this via the `cache_repo` property.
"ENVBUILDER_DOCKER_CONFIG_BASE64" : data.local_sensitive_file.envbuilder_cache_dockerconfigjson.content_base64,
"USE_CAP_NET_ADMIN" : "true",
# Set git commit details correctly
Expand Down