Skip to content

chore: enable noConsoleLog lint #14329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2024
Merged

chore: enable noConsoleLog lint #14329

merged 2 commits into from
Aug 16, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Aug 16, 2024

No description provided.

@aslilac aslilac added the hotfix label Aug 16, 2024
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

Copy link

alwaysmeticulous bot commented Aug 16, 2024

✅ Meticulous spotted zero visual differences across 1428 screens tested: view results.

Meticulous tested none of the executable lines edited in this PR. If this PR does not modify your frontend this is expected. If this is a new feature or Meticulous was recently introduced then Meticulous will generate tests to cover your code in the coming days1.

1. If you wish to increase coverage immediately you can do so by interacting with your feature on localhost.

Expected differences? Click here. Last updated for commit 65b1c2e. This comment will update as new commits are pushed.

@aslilac aslilac merged commit 7142cbb into main Aug 16, 2024
30 checks passed
@aslilac aslilac deleted the no-console-log branch August 16, 2024 16:12
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant