Skip to content

chore: remove dangling eslint-ignore comments #14334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 19, 2024
Merged

chore: remove dangling eslint-ignore comments #14334

merged 5 commits into from
Aug 19, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Aug 16, 2024

  • Remove a bunch of ESLint comments from places we no longer use it
  • Remove some usage of any from the type generator (to keep Biome happy)

@aslilac aslilac force-pushed the update-apitypings branch from 36d30a4 to 32294ad Compare August 16, 2024 20:50
Copy link

alwaysmeticulous bot commented Aug 16, 2024

✅ Meticulous spotted zero visual differences across 1428 screens tested: view results.

Meticulous tested 92/94 of the executable lines edited in this PR1.

1. These lines will likely automatically gain test coverage over the coming days, however if you wish to increase coverage immediately you can do so by interacting with your feature on localhost.

Expected differences? Click here. Last updated for commit ce20dbe. This comment will update as new commits are pushed.

@aslilac aslilac requested review from a team and code-asher and removed request for a team August 19, 2024 16:43
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

@aslilac aslilac merged commit 1c3dc83 into main Aug 19, 2024
35 checks passed
@aslilac aslilac deleted the update-apitypings branch August 19, 2024 22:08
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants