chore: update editorconfig with new tabs default #14335
Conversation
|
✅ Meticulous spotted zero visual differences across 1477 screens tested: view results. Expected differences? Click here. Last updated for commit e595808. This comment will update as new commits are pushed. |
There was a problem hiding this comment.
oh! I didn't notice we had a second one of these inside site/. good catch!
I think it makes more sense to change the default though (since basically every file in this folder should use tabs now) rather than add them as an exception.
Something like...
[*]
indent_style = tab
indent_size = 2
[node_modules/**]
ignore = true(settings indent_size is actually still important for non-obvious reasons)
|
Makes sense to me! Good point on |
|
Actually, does |
|
I would hope not, but it can be important for stuff like yaml files that don't support tab indentation. we can try leaving it unset for now if you'd like, and we can always set it later if it's causing issues. |
|
Sweet, lemme unset it for now then. I just did some brief testing with VS Code and the editorconfig plugin and it did change the visual tab width which seems kinda insane to me but I suppose it is what it is |
I explicitly added
tsxandtssince I am not sure if we have other file types that got changed to tabs, lemme know if I missed some.