fix: show org summary page if not entitled #14336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Meticulous spotted visual differences in 2 of 1428 screens tested: view and approve differences detected. Meticulous tested 4/5 of the executable lines edited in this PR1. 1. These lines will likely automatically gain test coverage over the coming days, however if you wish to increase coverage immediately you can do so by interacting with your feature on localhost. Last updated for commit fc7e2d4. This comment will update as new commits are pushed. |
You cannot edit the settings without being entitled, so show the summary page instead.
9ef3da7 to
fc7e2d4
Compare
aslilac
approved these changes
Aug 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up some things from #13915
You cannot edit the org settings without being entitled, so show the summary page instead.
I am really not sure this is the best long-term solution, but it at least prevents folks from submitting a form that will just error. Possibly we should also add a banner or something that says "if you want to edit this organization you need a license".
Hiding the org(s) on the sidebar entirely would also be an option, but, if they were previously licensed and it expired or something would it cause unnecessary panic that the org(s) suddenly disappeared?
And it does seem a little weird to me somehow to have a new org link but not be listing the orgs that exist even if it is just the default org, although I cannot quite put my finger on why. Might just generally be my preference to show everything but disable as necessary over hiding things.
I suppose we could hide the entire organizations section along with the new org link, but then how would you discover that orgs are a thing? Currently if you go into the new org page you can learn that a license is required. We could have just the organizations heading and then a small sidebar version of the license banner, maybe?