Skip to content

chore: update secondary and disabled text colors #14355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

jaaydenh
Copy link
Contributor

@jaaydenh jaaydenh commented Aug 19, 2024

The goal of this PR is to increase the contrast between the primary and secondary text to make it a little clearer to see what the relationship of information in the UI. This brings the design more in line with products such as Vercel that use a higher contrast between primary and secondary text.

Dark ---------

dark-old dark-new

Blue ---------
blue-old
blue-new

White ---------
white-old
white-new

Copy link

alwaysmeticulous bot commented Aug 19, 2024

🤖 Meticulous spotted visual differences in 1473 of 1477 screens tested: view and approve differences detected.

Meticulous tested 100% of the executable lines edited in this PR.

Last updated for commit e43f487. This comment will update as new commits are pushed.

Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just be sure you go through all the Chromatic changes very carefully 🙏

Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seconding what Bruno said, but it looks good from the screenshots!

@jaaydenh jaaydenh merged commit fb6b954 into main Aug 26, 2024
34 checks passed
@jaaydenh jaaydenh deleted the jaaydenh/secondary-text-colors branch August 26, 2024 16:22
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants