Skip to content

chore(site): make info gray #14356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 20, 2024
Merged

chore(site): make info gray #14356

merged 13 commits into from
Aug 20, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Aug 19, 2024

rather than having two yellows (warning and notice), I propose making notice the blue role rather than info, and make info a neutral gray.

Copy link

alwaysmeticulous bot commented Aug 19, 2024

🤖 Meticulous spotted visual differences in 59 of 1521 screens tested: view and approve differences detected.

Meticulous tested 72/85 of the executable lines edited in this PR1.

1. These lines will likely automatically gain test coverage over the coming days, however if you wish to increase coverage immediately you can do so by interacting with your feature on localhost.

Last updated for commit 090a2aa. This comment will update as new commits are pushed.

@aslilac aslilac requested review from a team and Parkreiner and removed request for a team August 19, 2024 21:50
@aslilac aslilac requested a review from jaaydenh August 19, 2024 23:31
@Parkreiner

This comment was marked as resolved.

@Parkreiner
Copy link
Member

Parkreiner commented Aug 20, 2024

@aslilac Do you know why the above wouldn't trigger a new Storybook? Storybook seems to have flagged virtually no changes

Can't tell if I'm missing something, but from what I can tell, the color wouldn't have changed until this PR

Comment on lines +65 to +74
info: {
background: colors.gray[950],
outline: colors.gray[400],
text: colors.gray[50],
fill: {
solid: colors.gray[500],
outline: colors.gray[600],
text: colors.white,
},
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that Tailwind technically saturates their colors so the problem won't be as pronounced, but is gray on blue going to look washed out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they look fine, and we can always tweak it going forward.

@aslilac
Copy link
Member Author

aslilac commented Aug 20, 2024

Do you know why the above wouldn't trigger a new Storybook? Storybook seems to have flagged virtually no changes

It did, I just approved all of the ones that I thought looked ok. I can keep the suggestions blue tho.

Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the stories, and I think the changes make a lot of sense!
The big thing I appreciate is that pending updates aren't as attention-grabby anymore

@aslilac
Copy link
Member Author

aslilac commented Aug 20, 2024

The big thing I appreciate is that pending updates aren't as attention-grabby anymore

I concur :^)

@aslilac aslilac merged commit 03f05e2 into main Aug 20, 2024
30 checks passed
@aslilac aslilac deleted the theme-improvements branch August 20, 2024 17:59
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants