-
Notifications
You must be signed in to change notification settings - Fork 875
chore(site): make info
gray
#14356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(site): make info
gray
#14356
Conversation
🤖 Meticulous spotted visual differences in 59 of 1521 screens tested: view and approve differences detected. Meticulous tested 72/85 of the executable lines edited in this PR1. 1. These lines will likely automatically gain test coverage over the coming days, however if you wish to increase coverage immediately you can do so by interacting with your feature on localhost. Last updated for commit 090a2aa. This comment will update as new commits are pushed. |
This comment was marked as resolved.
This comment was marked as resolved.
@aslilac Do you know why the above wouldn't trigger a new Storybook? Storybook seems to have flagged virtually no changes Can't tell if I'm missing something, but from what I can tell, the color wouldn't have changed until this PR |
info: { | ||
background: colors.gray[950], | ||
outline: colors.gray[400], | ||
text: colors.gray[50], | ||
fill: { | ||
solid: colors.gray[500], | ||
outline: colors.gray[600], | ||
text: colors.white, | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that Tailwind technically saturates their colors so the problem won't be as pronounced, but is gray on blue going to look washed out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they look fine, and we can always tweak it going forward.
It did, I just approved all of the ones that I thought looked ok. I can keep the suggestions blue tho. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through the stories, and I think the changes make a lot of sense!
The big thing I appreciate is that pending updates aren't as attention-grabby anymore
I concur :^) |
rather than having two yellows (
warning
andnotice
), I propose makingnotice
the blue role rather thaninfo
, and makeinfo
a neutral gray.